Fix erroneous indent between closers of auto-pairs #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inserting a newline between 2 closers of an auto-pair.
kirawi
added
A-helix-term
the-mikedavis
approved these changes
Dec 29, 2022
semin-park
pushed a commit
to semin-park/helix
that referenced
this pull request
Jan 4, 2023
inserting a newline between 2 closers of an auto-pair.
hadronized
pushed a commit
to hadronized/helix
that referenced
this pull request
Jan 4, 2023
inserting a newline between 2 closers of an auto-pair.
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
inserting a newline between 2 closers of an auto-pair.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, inserting a newline sometimes creates an additional indent (and an additional line) even if the cursor is not between matching auto-pairs:
Pressing enter when the cursor is on the second closing bracket results in the following text and indented cursor:
This commit fixes that issue (which occured whenever the cursor was between 2 closers of some auto-pair) and the wrong documentation that probably caused this in the first place.