Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tutor: add chapter for commenting lines #5211

Merged
merged 1 commit into from
Dec 26, 2022
Merged

tutor: add chapter for commenting lines #5211

merged 1 commit into from
Dec 26, 2022

Conversation

uncomfyhalomacro
Copy link
Contributor

Hello. Just a small addition to the tutor. :D

@kirawi kirawi added A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 20, 2022
michaeljones
michaeljones reviewed Dec 23, 2022
View reviewed changes
the-mikedavis
the-mikedavis reviewed Dec 24, 2022
View reviewed changes
@uncomfyhalomacro uncomfyhalomacro force-pushed the improve-tutor branch 4 times, most recently from 52178eb to e591f90 Compare December 25, 2022 18:45
@uncomfyhalomacro
Copy link
Contributor Author

Okay. Done formatting and making the body the same number of lines as other sections. Thanks for the review! ❤️

@gabydd
Copy link
Member

gabydd commented Dec 25, 2022

I have been working on #4718 it only changes the Ctrl-c binding a bit see my most recent comment but I think once this is merged we should add something about how you can block comment (<space>cb) is what it's binded to in the pr right now

@uncomfyhalomacro
Copy link
Contributor Author

That's awesome. I guess we can just leave this PR open until that gets merged

@the-mikedavis
Copy link
Member

We can take this as-is: it looks like the current behavior of C-c in #4718 on plaintext files is unchanged. We can revise this section with future changes once they're merged 👍

the-mikedavis
the-mikedavis approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@the-mikedavis the-mikedavis merged commit a637461 into helix-editor:master Dec 26, 2022
@gabydd
Copy link
Member

gabydd commented Dec 26, 2022

We can take this as-is: it looks like the current behavior of C-c in #4718 on plaintext files is unchanged. We can revise this section with future changes once they're merged 👍

That's what I was thinking as well I realize that probably wasn't clear in my comment

hadronized pushed a commit to hadronized/helix that referenced this pull request Jan 4, 2023
@hadronized
tutor: add chapter for commenting lines (helix-editor#5211)
6cbe7fb
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
tutor: add chapter for commenting lines (helix-editor#5211)
df1060d
@goyalyashpal goyalyashpal mentioned this pull request Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljones michaeljones michaeljones left review comments

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uncomfyhalomacro @gabydd @the-mikedavis @michaeljones @kirawi