fix: unreachable panic because of crossterms default-enabled brackete… #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-paste
When trying to paste using ctrl-shift-v helix would panic.
This is the case because in crossterm 0.25
[features]
default = ["bracketed-paste"]
is enabled, which would lead to a panic in helix-view/src/input.rs
unreachable!("crossterm shouldn't emit Paste events without them being enabled")
After setting default features to false for crossterm 0.25,
the use of crossterm::event::Event::Paste now leads to a compiler error because it is no longer included.
After removing the single use of Event::Paste, helix successfully compiles, doesn't panic
and pasting using ctrl-shift-v also works.
|
Ok. I will close this PR if the feature lands or it is no longer needed for other reasons. |
|
Merged #3233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d-paste
When trying to paste using
ctrl-shift-v,helixwouldpanic!.This is the case because in
crossterm 0.25is enabled, which would lead to a panic in
helix-view/src/input.rsunreachable!("crossterm shouldn't emit Paste events without them being enabled")After setting
default-features = falseforcrossterm 0.25, the use ofcrossterm::event::Event::Pastenow leads to a compiler error because it is no longer included.After removing the single use of Event::Paste, helix successfully compiles, doesn't panic, the tests pass and pasting using ctrl-shift-v also works.