Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a run-shell-command-no-output command #3247

Closed
wants to merge 3 commits into from

Conversation

dariooddenino
Copy link
Contributor

Hi!
This PR adds an additional command to run a shell command ignoring the output.

The command is :run-shell-command-no-output (alias :sh!).

I'm a bit uncertain about the usage of ShellBehavior::Ignore and Append, but I didn't want to use a boolean.

@the-mikedavis
Copy link
Member

Two things:

  • I don't think this is an appropriate use of ! in the alias name. Elsewhere ! always signals "force" behavior like :q!. Here I'm kinda confused by its meaning.
  • This should be async - :run-shell-command-no-output sleep 5 for example blocks the whole editor for a while. Without output I can't think of any reason to block. We should probably not be blocking in :sh either.

@dariooddenino
Copy link
Contributor Author

I agree completely! What would a more appropriate name be?
:sh-no-output is not that much of a shorter alias.
I think the corresponding bash ways to do so don't translate that well to a short name.

@the-mikedavis
Copy link
Member

I think it should be :shush :P

@the-mikedavis
Copy link
Member

the-mikedavis commented Aug 6, 2022

Looks like this needs a run of cargo fmt but otherwise this looks good (whoops, forgot about the async point although that might be better served by https://github.com/helix-editor/helix/pull/3029/files)

@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2022
@pascalkuthe
Copy link
Member

Closing because this has gone pretty stale. We would still like to see this but as a flag for sh instead of a new command once we have a command flag parswe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants