Rework soft wrap to allow split priorities. #12778
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new algorithm works by buffering the last maxwrap graphemes. When it needs to split a line, it looks for the best split within this buffer. What I like most about this strategy is that the split_priority function can be easily overridden in the future, for example it could use the unicode line breaking algorithm to decide on possible splits, and the rest of the implementation could stay exactly the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new algorithm works by buffering the last maxwrap graphemes. When it needs to split a line, it looks for the best split within this buffer.
What I like most about this strategy is that the split_priority function can be easily overridden in the future, for example it could use the unicode line breaking algorithm to decide on possible splits, and the rest of the implementation could stay exactly the same.
Fixes #11428