-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Helix Selection Renderer in Markdown (.multicursor
file type)
#12706
Open
nik-rev
wants to merge
23
commits into
helix-editor:master
Choose a base branch
from
nik-rev:render-helix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+200
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-rev
changed the title
feat: Helix markdown selection renderer
feat: Helix Selection Renderer (in Markdown)
Jan 27, 2025
nik-rev
changed the title
feat: Helix Selection Renderer (in Markdown)
feat: Helix Selection Renderer
Jan 28, 2025
This was referenced Jan 28, 2025
nik-rev
changed the title
feat: Helix Selection Renderer
feat: Helix Selection Renderer in Markdown (Jan 28, 2025
.multicursor
file type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for rendering Helix selections in markdown components:
Renders as:
It'll nicely complement #997 when that gets merged.
Here is the kind of workflow I'm envisioning:
:help
completer will show these Helix selections when you press tab to go see different commands. You'll be able to access the documentation on each command just by holdingtab
This PR just implements the renderer. The other stuff can be added in a different PR :-)
Tracked by #12714