Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zebra-stripe option #12694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noahbald
Copy link

This PR adds zebra-striping in response to #12655

  • display horitonzal highlights for every other line

image

@noahbald
Copy link
Author

noahbald commented Jan 27, 2025

Not sure if docs should be updating, I ran cargo xtask docgen and no changes were emitted.
Do I need to update docs and themes manually?

@nik-rev
Copy link
Contributor

nik-rev commented Jan 27, 2025

So I first thought this looks odd, but honestly I can see myself using this. I really like this addition!

@drybalka
Copy link
Contributor

drybalka commented Feb 2, 2025

I don't want to sound negative, but doesn't it fare too far into the plugin territory? This adds yet another config option that needs to be documented (and then read by users) and requires every color theme to provide zebra-stripe highlight.

@noahbald
Copy link
Author

noahbald commented Feb 2, 2025

I don't want to sound negative, but doesn't it fare too far into the plugin territory? This adds yet another config option that needs to be documented (and then read by users) and requires every color theme to provide zebra-stripe highlight.

I think that's fair, I wasn't too sure either. I made this mainly because it's a must-have for me to be comfortable in an editor and I want to be able to use it in my fork, as others may want.
If the priority is to keep the core editor minimal I'm happy to close the PR and wait until plugins are ready if that's more ideal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants