Warn against overwriting directories #12654
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn against overwriting directories if the destination path doesn't end with a directory separator.
test-dir
and atest-file.txt
inside (so we end withtest-dir/test-file.txt
):n
to create a new buffer and add some content to it:w test-dir
to save the new buffer (note the directory name is used without the trailing slash)test-dir
as a filetest-dirp4F0MM.bck/
).While not a critical data loss bug (the backup-rename of the original directory happens every time) it would be nice to prevent this situation in the first place, very much like we warn against external modifications by checking modification time.