Use separate color for primary selection in jetbrains_dark
#12606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
changed the title
jetbrains_dark
|
\cc @ynuwenhof what do you think? |
ynuwenhof
reviewed
Jan 27, 2025
runtime/themes/jetbrains_dark.toml
Outdated
Comment on lines
49
to
50
| "ui.selection" = { bg = "blue131" } | ||
| "ui.selection.primary" = { bg = "blue173" } |
There was a problem hiding this comment.
Suggested change
| "ui.selection" = { bg = "blue131" } | |
| "ui.selection.primary" = { bg = "blue173" } | |
| "ui.selection" = { fg = "black", bg = "blue214" } | |
| "ui.selection.primary" = { bg = "blue131" } |
I would probably set ui.selection.primary to the previous color of ui.selection and fix the cursor color to align with the original.
There was a problem hiding this comment.
@ynuwenhof I just tried your suggestion, but that doesn't work out. This way the cursor is not visible at all if there is no selection.
There was a problem hiding this comment.
Have you added blue214 = "#ced0d6" to the palette section? I forgot to include that in my code suggestion.
There was a problem hiding this comment.
Ah, that's why you've added that other comment, I wasn't aware 🙈 Adjusted it accordingly.
Co-authored-by: Yannic Nuwenhof <ynuwenhof@pm.me>
This reverts commit 72d5dc5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to use the
jetbrains_darktheme, and realized that there was no primary selection color set. That caused some issues, e.g. it is not visible which selection is the primary one.