Stop picker before looping #12528
Open
Stop picker before looping #12528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PgDown/PgUp - Not Being at the edge after looping is confusing. Especially on single-page lists the jumps seam random. Also alligned the PgDown / HalfPgDown shortcuts with the ones used in the editor.
|
To illustrate, in this recording I first open the current master branch
Then I repeat with my proposed change. I think that the current page-down / page-up is not very intuitive or useful in how it moves on loops, and this PR could be a very nice improvement. simplescreenrecorder-2025-01-15_10.21.52.mp4 |
Co-authored-by: Mathew Horner <105067994+mathew-horner@users.noreply.github.com>
kirawi
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PgDown / PgUp - Not being at the edge after looping is confusing. Especially on single-page lists the jumps seem random.
Also aligned the PgDown / Half-PgDown shortcuts with the ones used in the editor.
Overall more intuitive picker experience.