Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dim modifier to diagnostic.unnecessary in catppuccin_mocha.toml #12391

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

nizamiza
Copy link
Contributor

@nizamiza nizamiza commented Jan 3, 2025

No description provided.

@the-mikedavis the-mikedavis merged commit 9dcc1f0 into helix-editor:master Jan 3, 2025
@nik-rev
Copy link
Contributor

nik-rev commented Jan 3, 2025

_ No description provided. _

could you also make a PR to add it here? https://github.com/catppuccin/helix

@uncenter
Copy link
Contributor

uncenter commented Jan 3, 2025

We might have to add a comment to that file to make it clear where updates should land first?

@nik-rev
Copy link
Contributor

nik-rev commented Jan 4, 2025

Yeah

@nizamiza so in the repo I linked, the file at the very root helix.tera is the template file which is responsible for generating 8 theme files in other subdirectories

If you would like to, you can edit this file with the same changes as you have here and then follow "Building the themes" instructions in that README to generate all the themes

thanks

@nik-rev
Copy link
Contributor

nik-rev commented Jan 4, 2025

We might have to add a comment to that file to make it clear where updates should land first?

Oh, so do you mean a comment like "place new changes below this line" in helix.tera?

@uncenter
Copy link
Contributor

uncenter commented Jan 4, 2025

Oh, so do you mean a comment like "place new changes below this line" in helix.tera?

I was thinking the comment would go in the file in Helix's repository, directing people to update the source repository directly before updating the Helix version of the file.

@nik-rev
Copy link
Contributor

nik-rev commented Jan 4, 2025

Oh, so do you mean a comment like "place new changes below this line" in helix.tera?

I was thinking the comment would go in the file in Helix's repository, directing people to update the source repository directly before updating the Helix version of the file.

Yeah, that makes sense. I'll send

Oh, so do you mean a comment like "place new changes below this line" in helix.tera?

I was thinking the comment would go in the file in Helix's repository, directing people to update the source repository directly before updating the Helix version of the file.

Ah, okay. That's a good idea! here is the PR for this: #12400

@nizamiza
Copy link
Contributor Author

nizamiza commented Jan 4, 2025

@NikitaRevenco oh, I see. I will look into the repo you linked and open a PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants