Add option to exclude the definition from references in LSP searches

[effinsky]

The first ref search result is actually definition that I started the search from:

As far as I'm concerned, it should not be listed at all. Relatedly, It would be cool if a jump happened straight to reference if only one exists, with the search window never appearing.

[the-mikedavis]

It's possible to configure this in the LSP references request: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#referenceContext. Currently we hard-code this to true but it could be configurable.

It would be cool if a jump happened straight to reference if only one exists, with the search window never appearing.

That is how goto-references should behave if the language server only sends one location:

helix/helix-term/src/commands/lsp.rs

Lines 878 to 880 in 63dcaae

	[location] => {
	jump_to_location(editor, location, offset_encoding, Action::Replace);
	}

[pascalkuthe]

It's possible to configure this in the LSP references request: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#referenceContext. Currently we hard-code this to true but it could be configurable.

I wanted to send a PR for this but didn't get around to this yet. Was it a concious choice to hardcode true here? It seems like false would be the better default here since you can always use gd instead. I didn't find prior discussion the last time I looked into this

[the-mikedavis]

The descision/code predates me (#8) but the true default seems sensible to me. IMO the definition is a reference - when I want to see and especially edit all instances of some symbol, I expect to see the definition too. I'm curious what other editors use for a default here.

[effinsky]

I'm cool with this being the default if most folks find that useful and/or consistent with their expectations. I'd just like to be able to exclude it in a cfg opt and jump straight to a sole reference other than the def as well.

[Omnikar]

I'd say a good default behaviour is listing the definition reference at the bottom of the list, which seems to already be how it behaves for Rust.