Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving increment/decrement useability and flexability #1645

Closed
premell opened this issue Feb 10, 2022 · 1 comment · Fixed by #1778
Closed

Improving increment/decrement useability and flexability #1645

premell opened this issue Feb 10, 2022 · 1 comment · Fixed by #1778
Labels
A-core Area: Helix core improvements C-enhancement Category: Improvements

Comments

@premell
Copy link

premell commented Feb 10, 2022

I have two ideas of how to improve the increment/decrement feature ( and ).

First of all I think it should increment the next number on the line, not just if you're over the number. The main problem with this is if there are two different numbers on the same line. But then you can just jump to the number, which you would have to do anyway with the current system. Basically its quite a big upside with little downside.

I also think one should be able to toggle a few other things than just numbers, for example switching between true/false. There also are not that many true/false statements and numbers that they would clog up the system. And worst case scenario you have to jump the thing you'd like to change, like it is now.

I'd also argue for making the function global, like what we did with the "f" function from vim. Since its quite unlikely that you mistakenly use it and that the consequences of doing so are very mild.

@premell premell added the C-enhancement Category: Improvements label Feb 10, 2022
@kirawi kirawi added the A-core Area: Helix core improvements label Feb 11, 2022
@sudormrfbin
Copy link
Member

Previous discussion on jumping to next number: #1027 (comment). I wonder if this should be revisited, since it's quite handy to have it warp to next number.

antoyo added a commit to antoyo/helix that referenced this issue Mar 9, 2022
antoyo added a commit to antoyo/helix that referenced this issue Mar 9, 2022
antoyo added a commit to antoyo/helix that referenced this issue Mar 9, 2022
archseer pushed a commit that referenced this issue Apr 1, 2022
* Jump to the next number on the line before incrementing

Partially fix #1645

* Refactor to avoid duplicating find_nth_next
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Helix core improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants