Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behaviour for adding newline before a line with a comment on it #12165

Closed
nik-rev opened this issue Dec 1, 2024 · 1 comment · Fixed by #12215
Closed

Incorrect behaviour for adding newline before a line with a comment on it #12165

nik-rev opened this issue Dec 1, 2024 · 1 comment · Fixed by #12215

Comments

@nik-rev
Copy link
Contributor

nik-rev commented Dec 1, 2024

Example 1

If you have a comment and your cursor is at |:

/// this is a comme|nt

Pressing I then Enter will have this effect:

/// |/// this is a comment

While this was expected:

<newline>
|/// this is a comment

Example 2

Also, if you have that same comment at the top of the file:

/// this is a comm|ent

Pressing O will have this effect:

<newline>
/// | /// this is a comment

While this was expected

/// |
/// this is a comment
@TornaxO7
Copy link
Contributor

TornaxO7 commented Dec 1, 2024

Ooof, I think this is introduced from my PR ;-; #10996 I can try to create a follow PR for this but currently it's a bit full for me but I can add a fix until the end of next week I think

TornaxO7 added a commit to TornaxO7/helix that referenced this issue Dec 8, 2024
TornaxO7 added a commit to TornaxO7/helix that referenced this issue Dec 8, 2024
TornaxO7 added a commit to TornaxO7/helix that referenced this issue Dec 8, 2024
TornaxO7 added a commit to TornaxO7/helix that referenced this issue Dec 8, 2024
TornaxO7 added a commit to TornaxO7/helix that referenced this issue Dec 8, 2024
TornaxO7 added a commit to TornaxO7/helix that referenced this issue Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants