Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README updates for iOS Simulator and Android Emulator setup #333

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

samgutentag
Copy link

@samgutentag samgutentag commented May 11, 2023

for real this time, gross merge but all the info made it 🙃

@samgutentag samgutentag requested a review from a team as a code owner May 11, 2023 19:51
@samgutentag samgutentag requested review from allenan, tyler-whitman and Perronef5 and removed request for a team May 11, 2023 19:51
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tyler-whitman tyler-whitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fixes just one other minor thing

- [Install a Virtual Device](https://developer.android.com/studio/run/emulator#avd) (`Nexus 5` with `UpsideDownCake` good default)
- When [installing the Android SDK](https://reactnative.dev/docs/environment-setup#android-sdk) use these:
- `Android 13.0`
- `Android SDK Platform 31`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for 13, this should be 33

@Perronef5
Copy link
Contributor

@samgutentag Another merge conflict 🙃

@ChewingGlass
Copy link
Contributor

@samgutentag want to resolve the comments here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants