Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feat/632 hip 109 (#634)" #660

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

ChewingGlass
Copy link
Collaborator

This reverts commit 10bbfcd.

Copy link
Contributor

@abhay abhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a reasonable revert. I'd keep the lint fixes but that's your choice.

@@ -104,7 +104,7 @@ export async function run(args: any = process.argv) {
rentReclaimAuthority: new PublicKey(argv.rentReclaimAuthority),
authority: subDaoAuth,
subDao,
startAuthority: new PublicKey(argv.startAuthority),
startAuthority: new PublicKey(argv.startAuthority)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep?

@@ -50,11 +50,11 @@ export async function run(args: any = process.argv) {
},
minimumPeriods: {
type: "number",
describe: "The new minimum number of periods",
describe: "The new minimum number of periods"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this and next?

import { init as initHeliumEntityManager } from "../packages/helium-entity-manager-sdk/src";
import {
init as initHeliumEntityManager
} from "../packages/helium-entity-manager-sdk/src";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this and next two?

@@ -295,6 +296,7 @@ describe("hexboosting", () => {
)
).amount;

console.log(pythPrice);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop?

@ChewingGlass ChewingGlass force-pushed the temp-revert/hip-109 branch 2 times, most recently from 40b0292 to da00ee9 Compare June 18, 2024 22:01
@ChewingGlass ChewingGlass force-pushed the temp-revert/hip-109 branch from da00ee9 to ca0139e Compare June 18, 2024 22:01
@ChewingGlass ChewingGlass merged commit ae6e396 into master Jun 21, 2024
34 checks passed
@ChewingGlass ChewingGlass deleted the temp-revert/hip-109 branch June 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants