Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR on HIP7 - Managing HIP Process #45

Closed
wants to merge 2 commits into from
Closed

PR on HIP7 - Managing HIP Process #45

wants to merge 2 commits into from

Conversation

anthonyra
Copy link
Contributor

@anthonyra anthonyra commented Sep 30, 2020

Initial Pull Request for HIP7

@abhay
Copy link
Contributor

abhay commented Sep 30, 2020

@anthonyra can you change the filename back so we can see the diff between what's currently in place and this proposal?

@anthonyra
Copy link
Contributor Author

@anthonyra can you change the filename back so we can see the diff between what's currently in place and this proposal?

Ahhh yes, that would make sense... new to the whole "teamwork" Github commits, fetches, merges, and Pull Requests. I'll be fixing that in a jiffy.

@anthonyra
Copy link
Contributor Author

@abhay I thought that each commit would allow a different Pull Request. However, it appears that if there is an active PR it'll combine all commits to that one. This might limit the use of PR comments for PR's on Running HIPs like my proposal for HIP7 describes if the author submits multiple PRs.

@jamiew
Copy link
Contributor

jamiew commented Oct 1, 2020

@anthonyra separating PRs from discussion is why we adopted Tracking Issues. For this one it is #26

This branch/PR now has your HIP0014 proposal in it and I can't merge (or push to your branch to fix). Happy to ping you on Discord to help walk through how to excise, I'm @jamiedubs there

@anthonyra
Copy link
Contributor Author

Closing this Pull Request due to re-submission

@anthonyra anthonyra closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants