DC Expensing Amendment to Charge for ACK frames #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiew
reviewed
Jun 17, 2020
README.md
Outdated
| @@ -11,7 +11,7 @@ More details on process and how to participate to come. | |||
| | 1 | [Longfi and LoRaWAN](https://github.com/helium/HIP/blob/master/0001-longfi-and-lorawan.md) | Merged | | |||
| | 2 | [Sign miner](https://github.com/helium/HIP/blob/master/0002-sign-miner.md) | Merged | | |||
| | 3 | [Over-the-air miner upates](https://github.com/helium/HIP/blob/master/0003-miner-update.md) | Merged | | |||
| | 4 | [Data credits](https://github.com/helium/HIP/blob/master/0004-data-credits.md) | Merged | | |||
| | 4 | [Exensing Data Credits for LoRaWAN Traffic](https://github.com/helium/HIP/blob/master/0004-data-credits.md) | Merged | | |||
There was a problem hiding this comment.
Thanks for the catch, @jamiew
|
Merged in, thanks for helping correct the HIP to its actual design now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current definition for how DCs are expensed for LoRaWAN traffic did not account for "empty" acknowledgement packets, ie: ACK frames that do not have FRMPayload or FOpts. I do not believe our intention was to make ACKs free, so this has been corrected.
In addition, article
0004is renamed from the generic "data credits" to "expensing data credits for lorawan", as the article itself is not nearly as broad as the original title suggested.