Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerlink – HIP19 third-party manufacturer application #121

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

BenoitDuffez
Copy link
Contributor

@BenoitDuffez BenoitDuffez commented Jan 27, 2021

@jamiew jamiew added the draft label Jan 29, 2021
@jamiew
Copy link
Contributor

jamiew commented Jan 29, 2021

Thank you, received and will review. In particular would like feedback from community on the security model

@shawaj
Copy link
Contributor

shawaj commented Jan 31, 2021

Might be worth formatting in the same way as other applications as well - i.e. in a single file not a folder with sub files...

@jamiew jamiew changed the title add Kerlink HIP19 submission Kerlink – HIP19 third-party manufacturer application Feb 18, 2021
@jamiew
Copy link
Contributor

jamiew commented Feb 24, 2021

I saw that someone from Kerlink will be on community call today which is great. Can see if any questions.

@jamiew
Copy link
Contributor

jamiew commented Feb 24, 2021

Per community call, conversations in Discord, and informal polling, there is wide support for approving Kerlink as a third-party manufacturer of Helium-compatible hotspots and I'm marking this proposal approved ✅

@jamiew jamiew merged commit f1caa3b into helium:master Feb 24, 2021
@shawaj
Copy link
Contributor

shawaj commented Feb 24, 2021

@jamiew no big deal, but would it be worth an update to https://github.com/helium/HIP/blob/master/0019-third-party-manufacturers.md#how-to-apply to add that you are allowed to put a folder with images? Kerlink application seems nice, due to the images, and allows them to all be hosted on GH, rather than links to off-site images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants