-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP 62: PoC Witness IP Check #422
Comments
I have some concerns with this proposal.
|
I echo these similar concerns, I have a couple of wide spread point-to-multi-point ubiquiti airmax sites w/ legitimate hotspots deployments at these locations that are linked over 5-15km wireless bridge links (1-2ms latency back to 'headend' bridge) that are providing valuable network coverage while hairpinning back through same LAN to WAN internet gateway. NOT cool at all if this tramples my rather unique solution, I know I may be an edge case but some thoughtful engineering needs to be taken into account for us types of 'outside the box' thinkers with the skillet and aptitude to deploy such novel architectures which benefit 'the people's network'. Certainly these types of valid deployments should not be punished. |
you should not be penalising people for having proper point to point setups. legitimate Point to point setups can be far longer than the 300m, listed above is a entry level model that does 15km. and CGNAT is present for most mobile providers and some fixed providers, so you would nerf 4g functionality ( for outdoor miners with sim cards ) straight away and regular hotspots on a fixed home connection. users behind CGNAT will have an issue with this implementation because this change will make hotspots unduly affected unfit for purpose of intended use. VPN use is legitimate also for businesses or those who live at a university or behind a NAT to NAT and for security . additionally for those who arent beind cgnat , the majority IPs are dynamic from ISP (unless a static ip is requested, or comes as part of the plan) , so it changes when you d/c or when your IP lease ends , resulting in an innocent users continually getting a banned IP for a dynamic IP allocated to them. the scope of this HIP affects alot more people than a "few" as mentioned in the HIP ,trying to ban by IP is flawed & targetting VPNs are a terrible idea. |
This hip is will be a very bad idea for detecting spoofers. You will detect innocent miners which behind cgnat or using dynamic ips. İ live in a residence of multiple blocks around 4 or 5 km Square with a public wifi for People living here. |
Hip 62 will do nothing but punish honest people because of cheaters, just like the 100 km rule brings. It is ignored that a different IP address can be obtained for each device. it protects cheaters and punishes honest people. How Does; If my device throws a beacon and 2-3 or more of those cheaters' devices witness, their testimony will be invalid, but what will my beacon reward be? |
I have some concerns about this proposal in its current form that it will penalize valid hotspot owners in an disproportional way compared to "cheaters". I'm one of those hotspot owners who's GeoIP is constantly misreported to be in the wrong country except for high intelligence accuracy (but expensive) GoeIP providers. Note that there is no requirement for an IP to be assigned an geographic location. The whois registration is the location of owning entity and can be vastly different from the actual device location. Everything else is either educated guessing or private discussions. Similarly in an different location the only viable option is cellular (4G/5G) via one specific provider. That provider's CGNNAT is so bad (connection lifetime, IP affinity) that it is not usable without VPN even for simple web browsing. So depending on VPN detection this may cause my hotspot to be flagged too (in this case VPN GeoIP and actual location is in the same country but the IP has an high potential to be flagged as "data center"). On the other side, how much of an effort is it for an cheater to adapt? The majority of the cost is likely for the first device (e.g. getting an static IP enabled) while cost comes rapidly down per device with additional devices (e.g. get an full network routed). I suspect the cost increase will be too low to substantially reduce the amount of cheaters. With that it feels like that it has an potential to reduce real coverage more than it penalizes cheaters. I'm not sure CGNAT has an real impact here right now because the p2p requirement for full miners will be broken already. That might change with the p2p requirement going away eventually. Last I'd wonder if other options have been considered like an incentive to build a "trust" network or "war drive" hotspots to either independently assert or challenge an location/coverage. Like done for other technologies e.g. cellmapper for cellular. |
Rendered view
Read the HIP:
https://github.com/helium/HIP/blob/main/0062-poc-witness-ip-check.md
Summary
Prevent spoofing by checking each witness's IP address against the beacon's IP address and other witnesses' IP addresses, while still allowing witnesses sharing the same IP address as the beacon to be considered valid under specific yet rather accessible conditions.
Additionally, prevent spoofing farms from hiding their miners behind VPNs by heavily restricting the use of VPNs on Helium hotspots.
The text was updated successfully, but these errors were encountered: