Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Urllib3 request hook #2

Closed
wants to merge 9 commits into from
Closed

Urllib3 request hook #2

wants to merge 9 commits into from

Conversation

ItayGibel-helios
Copy link

Description

Adding an option for an extended form of Urllib3 request hook with additional two arguments:

  1. headers - a dictionary containing the request headers
  2. body - a string containing the encoded request body

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Added a unit test named test_extended_request_hook testing the extended arguments

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

nozik
nozik approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@nozik nozik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Please don't merge this PR - but rather open a PR to the upstream repository.

@ItayGibel-helios
Copy link
Author

@nozik
I added a new commit
after an OTEL reviewer commented on my PR and said it is ok to break the existing code - I made my _ExtenededRequestHookT type the only supported hook type

@nozik
Copy link
Member

nozik commented Sep 5, 2021

@ItayGibel-heliosphere 👍

@ItayGibel-helios
Copy link
Author

Merged in the original repo

@nozik nozik deleted the urllib3_request_hook branch November 7, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nozik nozik nozik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItayGibel-helios @nozik