Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for users to control the outcome of a WebSocket upgrade request #8594

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Apr 1, 2024

Description

Adds support for users to control the outcome of a WebSocket upgrade request. If the user handler returns a non-101 code, the protocol upgrade fails and a response is written back based on the data returned by the handler, including the error code, headers and the reason for the failure. See issue #7953. Some new tests.

…request. If the user handler returns a non-101 code, the protocol upgrade fails and a response is written back based on the data returned by the handler, including the error code, headers and the reason for the failure. See issue 7953. Some new tests.
@spericas spericas added 3.x Issues for 3.x version branch websocket WebSocket in Helidon labels Apr 1, 2024
@spericas spericas self-assigned this Apr 1, 2024
@spericas spericas marked this pull request as draft April 1, 2024 15:18
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 1, 2024
@spericas spericas added this to the 3.2.8 milestone Apr 2, 2024
…sponse. Some other minor cleanup.

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas requested a review from danielkec April 3, 2024 15:05
@spericas spericas marked this pull request as ready for review April 3, 2024 15:05
@spericas spericas merged commit 47f273e into helidon-io:helidon-3.x Apr 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch OCA Verified All contributors have signed the Oracle Contributor Agreement. websocket WebSocket in Helidon
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants