Include requested URI config in ListenerConfig; fix config keys #8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -154,7 +159,7 @@ public Builder trustedProxies(AllowList trustedProxies) { | |||
| * @param discoveryTypes discovery types to use | |||
| * @return updated builder | |||
| */ | |||
| @ConfiguredOption | |||
| @ConfiguredOption(key = "types") | |||
There was a problem hiding this comment.
I think a better option would be to have a new method called types, and deprecate the discoveryTypes one.
This way we align config key and method name, as should be the default in Helidon
tomas-langer
approved these changes
Feb 14, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…don-io#8371) * Include requested URI config in ListenerConfig; fix config keys * Forward-port requested URI discovery tests from 3.x * Review comments
tvallin
pushed a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
…don-io#8371) * Include requested URI config in ListenerConfig; fix config keys * Forward-port requested URI discovery tests from 3.x * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8367
Resolves #8372
The
ListenerConfigBlueprintdeclaredrequestedUriDiscoveryContextbut did not annotate it with@Option.Configuredso Helidon never processed configuration for it.Changes:
requestedUriDiscoveryContextonListenerConfigBlueprintso it is configured asrequested-uri-discoveryand optional.RequestedUriDiscoveryContext. It does not yet use the new builder approach and needs to at some point; to get this PR completed more quickly that is not part of this PR.Documentation
Bug fix; no doc impact.