OidcEncryption#generateMasterPassword check file system support posix before setting permission
#8296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tvallin <thibault.vallin@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: tvallin <thibault.vallin@oracle.com>
tomas-langer
previously requested changes
Jan 25, 2024
...ders/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcEncryption.java
Outdated
Show resolved
Hide resolved
...ders/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcEncryption.java
Outdated
Show resolved
Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
tvallin
force-pushed
the
oidc-encryption
branch
from
380f3a6
to
b263cda
Compare
Signed-off-by: tvallin <thibault.vallin@oracle.com>
romain-grecourt
approved these changes
Feb 14, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…ix before setting permission (helidon-io#8296) * check file system support posix before setting permission Signed-off-by: tvallin <thibault.vallin@oracle.com> * Add debug logging Signed-off-by: tvallin <thibault.vallin@oracle.com> * review changes Signed-off-by: tvallin <thibault.vallin@oracle.com> * do not set file permission on windows Signed-off-by: tvallin <thibault.vallin@oracle.com> --------- Signed-off-by: tvallin <thibault.vallin@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #8288
Documentation
No impact