Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Update gRPC version to 1.60.0 #8113

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

thegridman
Copy link
Collaborator

Update gRPC version to 1.60.0

Documentation

This PR is to fix issue #8106

The gRPC Java libraries now have automatic module names in the jar files. These names differ slightly from those previously used by Helidon as they are all prefixed with io.grpc instead of just grpc. An issue resulting from this is that the gRPC API module has a module name of io.grpc which is the same as the repackaged gRPC module in Helidon. The Helidon repackaged io.grpc module no longer has any code, it is just a pom file with some dependencies. Its io.grpc module name is generated from the artifactId. We cannot change the artifactId but we can add a module-info to the jar to set its module name to be something other than io.grpc.

Usages of the repackaged io.grpc module have been removed from the rest of Helidon, other modules in Helidon now depend directly on whatever gRPC libraries they require. The repackaged io.grpc module has been left in place so as not to break any customer's that depend on it. Having said that, customer code that uses gRPC libraries is almost certainly going to break anyway due to the change of module names, which is beyond our control.

@thegridman thegridman added grpc 3.x Issues for 3.x version branch labels Dec 8, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 8, 2023
@thegridman thegridman changed the title WIP: Update gRPC version to 1.60.0 Update gRPC version to 1.60.0 Dec 13, 2023
@thegridman thegridman merged commit c3ef7a5 into helidon-io:helidon-3.x Dec 13, 2023
12 checks passed
@thegridman thegridman deleted the grpc-update branch December 13, 2023 07:59
@barchetta barchetta changed the title Update gRPC version to 1.60.0 3.x: Update gRPC version to 1.60.0 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch grpc OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants