-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Update gRPC version to 1.60.0 #8113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Dec 8, 2023
barchetta
reviewed
Dec 11, 2023
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerConfiguration.java
Outdated
Show resolved
Hide resolved
…to deprecation of corresponding methods in the gRPC Java API.
thegridman
force-pushed
the
grpc-update
branch
from
December 12, 2023 09:31
4491370
to
c16f939
Compare
danielkec
requested changes
Dec 12, 2023
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerConfiguration.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerConfiguration.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerConfiguration.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerConfiguration.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerConfiguration.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerImpl.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerImpl.java
Outdated
Show resolved
Hide resolved
barchetta
reviewed
Dec 12, 2023
danielkec
approved these changes
Dec 12, 2023
thegridman
changed the title
WIP: Update gRPC version to 1.60.0
Update gRPC version to 1.60.0
Dec 13, 2023
barchetta
changed the title
Update gRPC version to 1.60.0
3.x: Update gRPC version to 1.60.0
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.x
Issues for 3.x version branch
grpc
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gRPC version to 1.60.0
Documentation
This PR is to fix issue #8106
The gRPC Java libraries now have automatic module names in the jar files. These names differ slightly from those previously used by Helidon as they are all prefixed with
io.grpc
instead of justgrpc
. An issue resulting from this is that the gRPC API module has a module name ofio.grpc
which is the same as the repackaged gRPC module in Helidon. The Helidon repackaged io.grpc module no longer has any code, it is just a pom file with some dependencies. Itsio.grpc
module name is generated from the artifactId. We cannot change the artifactId but we can add a module-info to the jar to set its module name to be something other thanio.grpc
.Usages of the repackaged
io.grpc
module have been removed from the rest of Helidon, other modules in Helidon now depend directly on whatever gRPC libraries they require. The repackagedio.grpc
module has been left in place so as not to break any customer's that depend on it. Having said that, customer code that uses gRPC libraries is almost certainly going to break anyway due to the change of module names, which is beyond our control.