Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webclient documentation #7812

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

klustria
Copy link
Member

No description provided.

@klustria klustria self-assigned this Oct 17, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 17, 2023
@klustria
Copy link
Member Author

This PR was created for issue #6456

@klustria klustria mentioned this pull request Oct 17, 2023
6 tasks
Copy link
Member

@Verdent Verdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor thing, but otherwise it looks good

docs/se/webclient.adoc Outdated Show resolved Hide resolved
@klustria klustria requested a review from Verdent October 17, 2023 16:14
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll make any small changes after the merge.

docs/se/webclient.adoc Show resolved Hide resolved
docs/se/webclient.adoc Show resolved Hide resolved
docs/se/webclient.adoc Show resolved Hide resolved
@klustria klustria dismissed Verdent’s stale review October 18, 2023 20:45

Dismissing so I can merge. The review feedback has already been resolved

@klustria klustria merged commit 477fcdf into helidon-io:main Oct 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants