Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of Priority with Weight in helidon-config #7776

Merged

Conversation

romain-grecourt
Copy link
Contributor

@romain-grecourt romain-grecourt commented Oct 11, 2023

Description

Replace usage of jakarta.annotation.Priority with io.helidon.common.Weight in helidon-config.

  • Add explicit dependency for jakarta.annotation-api in modules that were relying on helidon-config
  • Updated helidon-webserver to use requires static jakarta.annotation
  • Updated both helidon-security-providers-abac and helidon-security-abac-role to add require jakarta.annotation
  • Updated helidon-security to remove requires jakarta.annotation
  • Updated helidon-security-providers-jwt to add an optional dependency on jakarta-annotation (requires static and <optional>true</option> because it contains javadoc links to jakarta.annotation.security annotations
  • Replaced usage of jakarta.annotation.Generated with io.helidon.common.Generated
  • Minor javadoc updates in helidon-config
  • Fix :configurable-javadoc-base-url: doc attribute (see Fix broken links for ServerThreadPoolSupplier and ScheduledThreadPoolSupplier in mp/fault-tolerance.adoc (#4899) #4909)

Fixes #7744

Documentation

doc impact: none

@romain-grecourt romain-grecourt self-assigned this Oct 11, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 11, 2023
@romain-grecourt romain-grecourt changed the title Replace usage of Priority with Weight in SE config Replace usage of Priority with Weight in helidon-config Oct 12, 2023
@romain-grecourt romain-grecourt merged commit e2718eb into helidon-io:main Oct 12, 2023
12 checks passed
@romain-grecourt romain-grecourt deleted the replace-Priority-with-Weight branch October 12, 2023 17:04
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 17, 2023
)

* Replace usage of jakarta.annotation.Priority with io.helidon.common.Weight in SE config.

- Minor javadoc updates

Fixes helidon-io#7744

* Update modules that were getting jakarta.annotation transitively via helidon-config

* Fix jwt javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace usages of jakarta.annotation.Priority with io.helidon.common.Weight in SE
2 participants