Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Reactive streams doc alignment #6458 #7723

Merged
merged 1 commit into from
Oct 11, 2023
Merged

4.x: Reactive streams doc alignment #6458 #7723

merged 1 commit into from
Oct 11, 2023

Conversation

danielkec
Copy link
Contributor

Fixes #6458

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 5, 2023
@danielkec danielkec linked an issue Oct 5, 2023 that may be closed by this pull request
DOCS: 4.x Reactive Streams #6458
Closed
8 tasks
@danielkec danielkec requested a review from ljamen October 5, 2023 07:33
@danielkec danielkec self-assigned this Oct 5, 2023
@danielkec danielkec added the docs label Oct 5, 2023
@danielkec danielkec changed the title 4.x Reactive streams doc alignment #6458 4.x: Reactive streams doc alignment #6458 Oct 5, 2023
ljamen
ljamen reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small update

docs/includes/reactivestreams/engine.adoc Show resolved Hide resolved
@ljamen ljamen self-requested a review October 11, 2023 13:22
ljamen
ljamen approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make the change in a sep PR. Let's merge this now.

@ljamen ljamen merged commit a9f4434 into helidon-io:main Oct 11, 2023
12 checks passed
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 17, 2023
@danielkec @dalexandrov
Reactive streams doc alignment helidon-io#6458 (helidon-io#7723)
ec2447c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen approved these changes

Assignees

@danielkec danielkec

Labels
docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOCS: 4.x Reactive Streams
2 participants
@danielkec @ljamen