Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Move webserver/benchmark/jmh to tests/benchmark/jmh #7690

Merged
merged 1 commit into from
Oct 2, 2023
Merged

4.x: Move webserver/benchmark/jmh to tests/benchmark/jmh #7690

merged 1 commit into from
Oct 2, 2023

Conversation

barchetta
Copy link
Member

Description

Move webserver/benchmark/jmh to tests/benchmark/jmh

Documentation

No impact

@barchetta barchetta added testing 4.x Version 4.x labels Sep 29, 2023
@barchetta barchetta self-assigned this Sep 29, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 29, 2023
tomas-langer
tomas-langer approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting this to be moved to webserver/tests, but I think this is acceptable as well.

@barchetta barchetta merged commit d04a8f8 into helidon-io:main Oct 2, 2023
12 checks passed
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 17, 2023
@barchetta @dalexandrov
Move webserver/benchmark/jmh to tests/benchmark/jmh (helidon-io#7690)
5fc6607
@barchetta barchetta deleted the 4.x-mv-benchmark branch January 11, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@barchetta barchetta

Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @tomas-langer