Document assumptions about types of current processing round #7072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
trentjeff
reviewed
Jun 23, 2023
| @@ -87,9 +87,10 @@ public static Optional<TypeName> createTypeName(TypeMirror typeMirror) { | |||
| case TYPEVAR -> { | |||
| return Optional.of(createFromGenericDeclaration(typeMirror.toString())); | |||
| } | |||
| case WILDCARD -> { | |||
| case WILDCARD, ERROR -> { | |||
There was a problem hiding this comment.
shouldn't we have a unit test for these returns?
There was a problem hiding this comment.
Can we get a TypeMirror instance in a unit test? These methods did not have unit tests before, so I guess you investigated this?
trentjeff
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7071