reactive removal from common/rest and vault #7033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
changed the title
integrations/common/rest/src/main/java/io/helidon/integrations/common/rest/RestApi.java
Outdated
Show resolved
Hide resolved
...tions/common/rest/src/main/java/io/helidon/integrations/common/rest/ApiOptionalResponse.java
Outdated
Show resolved
Hide resolved
.../auths/approle/src/main/java/io/helidon/integrations/vault/auths/approle/AppRoleRestApi.java
Outdated
Show resolved
Hide resolved
...uths/approle/src/main/java/io/helidon/integrations/vault/auths/approle/AppRoleVaultAuth.java
Outdated
Show resolved
Hide resolved
...ations/vault/auths/k8s/src/main/java/io/helidon/integrations/vault/auths/k8s/K8sRestApi.java
Outdated
Show resolved
Hide resolved
...ault/auths/token/src/main/java/io/helidon/integrations/vault/auths/token/TokenVaultAuth.java
Outdated
Show resolved
Hide resolved
...ault/auths/token/src/main/java/io/helidon/integrations/vault/auths/token/TokenVaultAuth.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/ClientRequest.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/WebClient.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/Http1Client.java
Outdated
Show resolved
Hide resolved
tomas-langer
previously requested changes
Jun 21, 2023
integrations/common/rest/src/main/java/io/helidon/integrations/common/rest/ApiJsonRequest.java
Outdated
Show resolved
Hide resolved
integrations/common/rest/src/main/java/io/helidon/integrations/common/rest/ApiRestRequest.java
Outdated
Show resolved
Hide resolved
integrations/common/rest/src/main/java/io/helidon/integrations/common/rest/RestApi.java
Outdated
Show resolved
Hide resolved
.../auths/approle/src/main/java/io/helidon/integrations/vault/auths/approle/AppRoleRestApi.java
Outdated
Show resolved
Hide resolved
...uths/approle/src/main/java/io/helidon/integrations/vault/auths/approle/AppRoleVaultAuth.java
Outdated
Show resolved
Hide resolved
...uths/approle/src/main/java/io/helidon/integrations/vault/auths/approle/AppRoleVaultAuth.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/ClientRequest.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/Http1Client.java
Outdated
Show resolved
Hide resolved
arjav-desai
force-pushed
the
helidon-6849
branch
from
ad6b191
to
82f176c
Compare
This was
linked to
issues
Jun 22, 2023
arjav-desai
force-pushed
the
helidon-6849
branch
2 times, most recently
from
0f4ec3c
to
23a0ffe
Compare
...tegrations/vault/hcp/src/main/java/io/helidon/examples/integrations/vault/hcp/VaultMain.java
Outdated
Show resolved
Hide resolved
...tions/common/rest/src/main/java/io/helidon/integrations/common/rest/ApiOptionalResponse.java
Outdated
Show resolved
Hide resolved
integrations/common/rest/src/main/java/io/helidon/integrations/common/rest/RestApi.java
Outdated
Show resolved
Hide resolved
...ations/vault/auths/k8s/src/main/java/io/helidon/integrations/vault/auths/k8s/K8sRestApi.java
Outdated
Show resolved
Hide resolved
...ations/vault/auths/k8s/src/main/java/io/helidon/integrations/vault/auths/k8s/K8sRestApi.java
Outdated
Show resolved
Hide resolved
...ions/vault/auths/k8s/src/main/java/io/helidon/integrations/vault/auths/k8s/K8sVaultAuth.java
Outdated
Show resolved
Hide resolved
...ault/secrets/pki/src/main/java/io/helidon/integrations/vault/secrets/pki/PkiSecretsImpl.java
Outdated
Show resolved
Hide resolved
...ault/secrets/pki/src/main/java/io/helidon/integrations/vault/secrets/pki/PkiSecretsImpl.java
Outdated
Show resolved
Hide resolved
arjav-desai
force-pushed
the
helidon-6849
branch
from
3b508e0
to
707e914
Compare
arjav-desai
dismissed
tomas-langer’s stale review
Dismissing for reapproval as suggested changes are incorporated.
romain-grecourt
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6849 , #6911 , #7029 and #7030