[3.x] - Add support for multiple baggage items #7022
Conversation
dalexandrov
added
enhancement
oracle-contributor-agreement
bot
added
the
OCA Verified
| port: 14250 | ||
| path: "/api/traces" | ||
| propagation: "w3c" |
There was a problem hiding this comment.
If you specify only w3c will there be any traceId/spanId/parentSpanId/sampled values propagated? I know this single test doesn't rely on that (only baggage), but won't any other tests that are influenced by this yaml have the side-effect of not getting their traceId etc? Just trying to understand.
There was a problem hiding this comment.
The w3c tracer documentation is available here: https://www.w3.org/TR/trace-context/
I think everything should be propagated correctly.
There was a problem hiding this comment.
To clarify the above statement further. When w3c is added to propagation, it causes the following to be used:
io.opentelemetry.api.baggage.propagation.W3CBaggagePropagator
And as you can tell from the name, it's only baggage. This was done in helidon-6611
f365e61
As a result, to get similar (but not identical) baggage propagation while still retaining X-B3-TraceId headers you must use "b3,w3c" as the propagation.
I say not identical because the old b3 JaegerClient propagation used 1 header per baggage item, ex:
baggage-foo=[fooValue], baggage-bar=[barValue]
Whereas the b3,w3c propagation now uses 1 baggage header for all values, ex:
baggage=[foo=fooValue, bar=barValue]
Resolves #7018