Update ByteBufferDataChunk.isReleased and ByteBufDataChunk.isReleased to use AtomicBoolean #6846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
… to use an AtomicBoolean. Fixes helidon-io#6845
romain-grecourt
changed the title
danielkec
reviewed
May 18, 2023
tests/integration/se-gh-6845/src/main/java/io/helidon/tests/integration/gh6845/Main.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
May 18, 2023
common/http/src/main/java/io/helidon/common/http/ByteBufferDataChunk.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
May 18, 2023
common/http/src/main/java/io/helidon/common/http/ByteBufferDataChunk.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
May 18, 2023
webserver/webserver/src/main/java/io/helidon/webserver/ByteBufDataChunk.java
Outdated
Show resolved
Hide resolved
ljnelson
previously approved these changes
May 18, 2023
danielkec
reviewed
May 19, 2023
common/http/src/main/java/io/helidon/common/http/ByteBufferDataChunk.java
Outdated
Show resolved
Hide resolved
danielkec
approved these changes
May 19, 2023
danielkec
previously requested changes
May 19, 2023
ljnelson
approved these changes
May 19, 2023
romain-grecourt
added a commit
to romain-grecourt/helidon
that referenced
this pull request
May 24, 2023
… to use AtomicBoolean (helidon-io#6846) * Update ByteBufferDataChunk.isReleased and ByteBufDataChunk.isReleased to use an AtomicBoolean. Fixes helidon-io#6845 * Remove bit magic, add comments * Use VarHandle * use ExceptionInInitializerError instead of RuntimeException * Use int instead of boolean for the volatile field * fix checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
ByteBufferDataChunk.isReleasedandByteBufDataChunk.isReleasedto use an AtomicBoolean.This prevents race conditions that may call the release callback more than once.
Fixes #6845