Interceptor Redo #6658
Interceptor Redo #6658
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -50,6 +51,7 @@ public interface Interceptor { | |||
| * | |||
| * @param args the arguments passed | |||
| * @return the result of the call | |||
| * @throws InvocationException if there is an errors during invocation chain processing | |||
There was a problem hiding this comment.
"there is an error during" or "there are errors during"
| @@ -32,6 +32,7 @@ public interface Interceptor { | |||
| * @param args the arguments to the call | |||
| * @param <V> the return value type (or {@link Void} for void method elements) | |||
| * @return the return value to the caller | |||
| * @throws InvocationException if there is an errors during invocation chain processing | |||
There was a problem hiding this comment.
either is an error or are errors - typo
|
My assumptions are a little different from yours. I expected that once the target of interception was successfully called once, then game over. The target can't be called again. However, If it threw an exception then it can be called again - but if it was completed then game over. You assume you should be able to call the target an infinite number of times really. I think both viewpoints have some merit, and perhaps we should make this into a qualifier type annotation on interceptors or something? |
| @@ -37,6 +37,7 @@ static Invocation lastCall() { | |||
| return LAST_CALL.getAndSet(null); | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
Curiously the SuppressWarnings("ALL") doesn't catch the unchecked vararg warnings in the generated interceptor - this did the trick though.
|
A qualifier such as |
|
Logged #6664 - Add @repeatable meta annotation qualifier on InterceptorTrigger |
Resolves Issue #6629