Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Upgrade Jakarta EL to 5.0.1 #6603

Merged
merged 2 commits into from
Apr 13, 2023
Merged

4.x: Upgrade Jakarta EL to 5.0.1 #6603

merged 2 commits into from
Apr 13, 2023

Conversation

barchetta
Copy link
Member

To align with Jakarta EE 10

@barchetta barchetta added dependencies Pull requests that update a dependency file 4.x Version 4.x labels Apr 12, 2023
@barchetta barchetta self-assigned this Apr 12, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 12, 2023
@barchetta barchetta mentioned this pull request Apr 12, 2023
Closed
18 tasks
@barchetta
Copy link
Member Author

barchetta commented Apr 12, 2023 •
edited
Loading

Failed test when running on module path:

** Running on module path
JWT token to use for /jwt requests: ***
2023.04.12 20:16:17 INFO io.helidon.logging.jul.JulProvider Thread[#1,main,5,main]: Logging at initialization configured using file: /home/runner/work/helidon/helidon/tests/integration/native-image/mp-1/logging.properties
Error: Exception in thread "main" java.lang.NoClassDefFoundError: jakarta/el/ELResolver
	at weld.core.impl@4.0.0-SNAPSHOT/org.jboss.weld.manager.BeanManagerImpl.<init>(BeanManagerImpl.java:360)
	at weld.core.impl@4.0.0-SNAPSHOT/org.jboss.weld.manager.BeanManagerImpl.newRootManager(BeanManagerImpl.java:317)
	at weld.core.impl@4.0.0-SNAPSHOT/org.jboss.weld.bootstrap.WeldStartup.startContainer(WeldStartup.java:231)
	at weld.core.impl@4.0.0-SNAPSHOT/org.jboss.weld.bootstrap.WeldBootstrap.startContainer(WeldBootstrap.java:73)
	at io.helidon.microprofile.cdi@4.0.0-

@tomas-langer I updated microprofile/cdi module-info to fix the above test failure by making sure jakarta.el in in the module graph. Let me know if that is the correct place to do it.

@barchetta barchetta merged commit 9c0c0de into helidon-io:main Apr 13, 2023
@barchetta barchetta deleted the 4.x-jakarta-el-5.0 branch May 31, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@barchetta barchetta

Labels
4.x Version 4.x dependencies Pull requests that update a dependency file OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barchetta @romain-grecourt @tomas-langer