Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable protocols #5883

Merged

Conversation

tomas-langer
Copy link
Member

Resolves #5416
Replaces PR #5682

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>

Issue 5416: Fixed javadoc error.

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@tomas-langer tomas-langer added webserver Níma Helidon Níma labels Jan 17, 2023
@tomas-langer tomas-langer self-assigned this Jan 17, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 17, 2023
/**
* HTTP/2 server configuration.
*/
@Builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need Builder and ConfigBean. ConfigBean is a specialization of Builder. You only need to use Builder if there is an attribute you want/need to override.

Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tomas-langer tomas-langer merged commit 34461e3 into helidon-io:main Jan 18, 2023
@tomas-langer tomas-langer deleted the 5416-configurable-protocols branch January 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Níma Helidon Níma OCA Verified All contributors have signed the Oracle Contributor Agreement. webserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants