Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress incorrect start-up log message related to requested URI discovery #5862

Merged

Conversation

tjquinno
Copy link
Member

Resolves #5859

Users can configure requested URI discovery explicitly as enabled=false with the discovery type of HOST. That's legitimate and is the normal case.

In fact, the code creates these settings internally if the user has not set up discovery settings explicitly.

Further, in the case of the default socket, the socket init code invokes SocketConfiguration#prepareAndCheckRequestedUriSettings twice, and the second time through the code was incorrectly logging the message (because it had itself previously established these settings).

In these cases, the code should not log the INFO message about ignoring explicit discovery type or trusted proxy settings when the feature is disabled.

@tjquinno tjquinno added this to the 3.1.1 milestone Jan 13, 2023
@tjquinno tjquinno self-assigned this Jan 13, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 13, 2023
@tjquinno tjquinno merged commit 80ffcb4 into helidon-io:helidon-3.x Jan 13, 2023
@tjquinno tjquinno deleted the requested-uri-discovery-log- branch January 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requested URI discovery feature displays an incorrect message during start-up
2 participants