Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException when there is an illegal character in the request #5471

Merged
merged 1 commit into from
Nov 18, 2022
Merged

NullPointerException when there is an illegal character in the request #5471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions webserver/webserver/src/main/java/io/helidon/webserver/ForwardingHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,9 @@ private boolean channelReadHttpRequest(ChannelHandlerContext ctx, Context reques
// New request ID
long requestId = REQUEST_ID_GENERATOR.incrementAndGet();


requestEntityAnalyzed = new CompletableFuture<>();

// If a problem with the request URI, return 400 response
BareRequestImpl bareRequest;
try {
Expand Down Expand Up @@ -389,8 +392,6 @@ private boolean channelReadHttpRequest(ChannelHandlerContext ctx, Context reques
prevRequestFuture = null;
}

requestEntityAnalyzed = new CompletableFuture<>();

//If the keep alive is not set, we know we will be closing the connection
if (!HttpUtil.isKeepAlive(requestContext.request())) {
this.requestEntityAnalyzed.complete(ChannelFutureListener.CLOSE);
Expand Down