Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New FT Nima executors and larger multiplier for TCK timeouts in pipeline #5317

Merged
merged 7 commits into from
Nov 7, 2022
Merged

New FT Nima executors and larger multiplier for TCK timeouts in pipeline #5317

merged 7 commits into from
Nov 7, 2022

Conversation

spericas
Copy link
Member

@spericas spericas commented Nov 3, 2022 •
edited
Loading

Summary of changes in this PR:

  • Replaces all executors in FT Nima to use VTs
    • Drops the ability to configure these executors using config (pool sizes are not needed with VTs)
  • Uses a larger multiplier for TCK timeouts
  • Fixes some potential race condition in BulkheadImpl
  • Tweaks some tests to ensure happens-before relationship guarantees
  • Multiple TCKs runs in pipeline without failures

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

@spericas
Try a larger multipler for timeouts in pipeline.
f2dc4a7 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added enhancement New feature or request testing labels Nov 3, 2022
@spericas spericas self-assigned this Nov 3, 2022
@spericas spericas mentioned this pull request Nov 3, 2022
Closed
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 3, 2022
barchetta
barchetta previously approved these changes Nov 3, 2022
View reviewed changes
@spericas
Pipeline test: different implementation of Timeout and improved mutua…
55ed29b 
…l exclusion in bulkheads.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas marked this pull request as draft November 3, 2022 17:58
@spericas
Replace old executors in FaultTolerance class to single one that use …
3caffd2 
…VTs. Simulate scheduled tasks with delayed callables/runnables. Remove ability to configure thread pool sizes etc. since it does not apply to VTs anymore.
@spericas spericas changed the title Try a larger multiplier for TCK timeouts in pipeline New FT Nima executors and larger multiplier for TCK timeouts in pipeline Nov 4, 2022
@spericas
Updated Async to use same executor from FaultTolerance class.
be26f5e 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
Increased timeout value.
88eb6ce 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
Always use BulkheadException.
cffdafc 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
Fixed race condition in test. Some tweaks to BulkheadImpl.
c7d5fd4
@spericas spericas marked this pull request as ready for review November 7, 2022 15:57
@spericas spericas merged commit 17bfd39 into helidon-io:main Nov 7, 2022
@spericas spericas linked an issue Nov 7, 2022 that may be closed by this pull request
4.x: fault.tolerance.tck.TimeoutTest.testGTDefaultTimeout intermittent failure #5306
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@spericas spericas

Labels
enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement. testing
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.x: fault.tolerance.tck.TimeoutTest.testGTDefaultTimeout intermittent failure
3 participants
@spericas @barchetta @tomas-langer