Extend Builder to support abstract and concrete codegen, and add validation of required attributes during builder().build() #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
trentjeff
commented
Oct 20, 2022
•
trentjeff
commented
- Adds builder attribute visitor.
- Uses Visitor for attribute validation of 'required' attributes (from ConfiguredOptions).
- For Singular, fixes the plurality of the verbs (addPickle instead of addPickles).
- Separates out Abstract Builder from Concrete Builder, and other review comments from Tomas.
oracle-contributor-agreement
bot
added
the
OCA Verified
trentjeff
force-pushed
the
pico2c
branch
3 times, most recently
from
3b580c3
to
edc8a62
Compare
trentjeff
changed the title
trentjeff
force-pushed
the
pico2c
branch
3 times, most recently
from
09acfa7
to
6328384
Compare
This was referenced Oct 26, 2022
trentjeff
force-pushed
the
pico2c
branch
4 times, most recently
from
5646b63
to
428f833
Compare
tomas-langer
requested changes
Nov 2, 2022
pico/builder/builder/src/main/java/io/helidon/pico/builder/BuilderTrigger.java
Outdated
Show resolved
Hide resolved
pico/builder/builder/src/test/java/io/helidon/pico/builder/spi/BeanUtilsTest.java
Outdated
Show resolved
Hide resolved
pico/builder/tests/builder/src/test/java/io/helidon/pico/builder/api/test/MyConfigBeanTest.java
Outdated
Show resolved
Hide resolved
pico/builder/tests/builder/src/test/java/io/helidon/pico/builder/api/test/UsageTest.java
Show resolved
Hide resolved
tomas-langer
approved these changes
Nov 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.