Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenMetrics formatting error (3.x) #4900

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Sep 15, 2022

The initial problem was that the OpenMetrics output format was not quite right. It lacked a trailing # EOF, it sometimes included a stray blank line, and we did not correctly deal with Accept and Content-Type for the application/openmetrics-text media type. (The issue was reported by a user who was having trouble with a Prometheus server that was set up to record exemplars complaining when it scraped a Helidon service's /metrics endpoint.)

Along the way I discovered that exemplars for SimpleTimer were incorrect so that fix is part of this PR also.

Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com

…ith exemplars on SimpleTimer; add tests

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno marked this pull request as ready for review September 16, 2022 15:09
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit 005679c into helidon-io:helidon-3.x Sep 20, 2022
@tjquinno tjquinno deleted the metrics-format-fix branch September 20, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants