Http exception refactoring #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ErrorHandlers (without actual implementation) to Nima. Use HttpException in Nima where appropriate
danielkec
reviewed
Aug 27, 2022
nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/http/ErrorHandlers.java
Show resolved
Hide resolved
danielkec
previously approved these changes
Aug 27, 2022
ljnelson
reviewed
Aug 27, 2022
common/http/src/main/java/io/helidon/common/http/ForbiddenException.java
Outdated
Show resolved
Hide resolved
barchetta
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpException moved to common http module.
RequestException (new thing) moved to common http module.
Document describing how exceptions should be handled in HTTP added to repository (internal docs).
ErrorHandlersadded to Nima (to be fully implemented later - already on task list).