Fix wrong connection close #3830
Conversation
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
webserver/webserver/src/main/java/io/helidon/webserver/BareResponseImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
| requestEntityAnalyzed = requestEntityAnalyzed.thenApply(listener -> { | ||
| LOGGER.fine(() -> log("Writing headers %s", status)); |
There was a problem hiding this comment.
Given the assignment in the line above, shouldn't we rename
requestEntityAnalyzed? Its name is too close to the new one added, yet its completion reflects more than just the request entity being processed?
There was a problem hiding this comment.
Not sure I understand - it is the same future. We just need to keep the original instance and complete on it, as the "last" isntance in the field will not reflect thenApply and other methods registered on previous instances.
There was a problem hiding this comment.
That's exactly the point, the last instance on this field is related to the writing of the response and no longer the analysis of the request entity (as its name suggests). My comment is just about naming, not semantics. Certainly not a stopper.
* Fix wrong connection close * Reduced logging overhead. Small improvements of tests. * Consume request entity on valid responses. Signed-off-by: Tomas Langer <tomas.langer@oracle.com> (cherry picked from commit 2a1dd6b)
Resolves #3829
Entity is consumed for any request that completed and did not subscribe (including JAX-RS).
We were consuming the entity anyway at a later stage (when we already did a connection close). For connection:close cases, entity is ignored if not consumed.
This keeps original handling and improved it even for requests with more than one chunk in request entity, while simplifying the code.
Signed-off-by: Tomas Langer tomas.langer@oracle.com