Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some interceptor code paths in metrics #3251

Merged
merged 16 commits into from
Aug 24, 2021
Merged

Improve some interceptor code paths in metrics #3251

merged 16 commits into from
Aug 24, 2021

Commits on Aug 19, 2021

  1. Perf improvements: Convert HashSet of work items to array list; mark … 

    …deleted metrics themselves to avoid hash look-up of metric ID to check if interceptor refers to deleted metric; do a bit of optimization in computing the exemplar label(s) when exemplars are not actually in use
    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    2162906 View commit details
    Browse the repository at this point in the history

  2. Fix copyrights

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    619391a View commit details
    Browse the repository at this point in the history

  3. Revert changes to MetricsTest

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    b0c763b View commit details
    Browse the repository at this point in the history

  4. Further optimize non-exemplar case in creating Sample instances

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    7a187d3 View commit details
    Browse the repository at this point in the history

  5. Correct a misspelling of an internal field; avoid creating a seemingl… 

    …y expensive lambda for FINEST logging; save and look-up which parameter position an async parameter occupies (if there is one) in a JAX-RS endpoint
    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    cffd969 View commit details
    Browse the repository at this point in the history

  6. Fix style issue with static field name

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    85f904c View commit details
    Browse the repository at this point in the history

  7. Further logging optimization in interceptors

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    fe54baf View commit details
    Browse the repository at this point in the history

  8. Make sure we don't add a work item to the WorkItemsManager more than … 

    …once, now that we use Lists (for in-request performance) instead of Sets
    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    9073f79 View commit details
    Browse the repository at this point in the history

  9. Avoid using some lambdas that were created during metrics updates

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    0434165 View commit details
    Browse the repository at this point in the history

  10. Refactor slightly to avoid lambdas

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    a0fcb94 View commit details
    Browse the repository at this point in the history

  11. Avoid fetch of current system time for exemplar support if label is e… 

    …mpty (meaning exemplars are not turned on)
    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    f963836 View commit details
    Browse the repository at this point in the history

  12. Change HelidonTimer.class.isInstance(var) to var instanceof HelidonTimer

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    b70059d View commit details
    Browse the repository at this point in the history

  13. Optimize creation of Sample.Labeled if exemplars are not enabled

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    f5eef06 View commit details
    Browse the repository at this point in the history

  14. Avoid computing current time in seconds on each update to Expoentiall… 

    …yDecaryingReservoir, because the value will change only every second
    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    54e6e85 View commit details
    Browse the repository at this point in the history

  15. Fix style issue

    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    472c492 View commit details
    Browse the repository at this point in the history

  16. Add general notification of REST service shutdown, and use it in metr… 

    …ics to stop the scheduled updates to 'current-time-in-minutes' values in ExponentiallyDecayingReservoir instances
    @tjquinno
    tjquinno committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    cb444d9 View commit details
    Browse the repository at this point in the history