Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust JSON timer histogram output using the units (if any) that were set on the timer (2.x) #3132

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Jun 18, 2021

Resolves #3088

For timers, the JSON output of the histogram data should use the timer's units to convert the values.

Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno requested a review from spericas June 18, 2021 13:34
@tjquinno tjquinno self-assigned this Jun 18, 2021
@barchetta barchetta added this to the 2.3.1 milestone Jun 18, 2021
@barchetta barchetta self-requested a review June 18, 2021 19:14
@tjquinno tjquinno merged commit 6533f97 into helidon-io:master Jun 18, 2021
@tjquinno tjquinno deleted the timer-units branch June 18, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A question related to @Timed metric units
3 participants