Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple support for Micrometer #2594

Closed
wants to merge 23 commits into from
Closed

Add simple support for Micrometer #2594

wants to merge 23 commits into from

Conversation

tjquinno
Copy link
Member

Resolves #2344

Adds MicrometerSupport in SE and a CDI extension and related interceptors, etc. for MP support.

@tjquinno tjquinno added this to the 2.2.0 milestone Dec 10, 2020
@tjquinno tjquinno self-assigned this Dec 10, 2020
@tjquinno
Copy link
Member Author

I have optimistically marked this with the 2.2.0 milestone. We'll see if I complete the MP work and the SE and MP doc and examples and can do adequate testing.

We might consider this an "experimental" feature for now??

@barchetta barchetta added dependencies Pull requests that update a dependency file enhancement New feature or request metrics 2.x Issues for 2.x version branch labels Dec 10, 2020
ljamen
ljamen reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes/typos.

docs/se/metrics/03_micrometer.adoc Outdated Show resolved Hide resolved
docs/se/metrics/03_micrometer.adoc Show resolved Hide resolved
docs/se/metrics/03_micrometer.adoc Outdated Show resolved Hide resolved
docs/se/metrics/03_micrometer.adoc Outdated Show resolved Hide resolved
docs/se/metrics/03_micrometer.adoc Outdated Show resolved Hide resolved
docs/se/metrics/03_micrometer.adoc Outdated Show resolved Hide resolved
docs/se/metrics/03_micrometer.adoc Outdated Show resolved Hide resolved
docs/se/metrics/03_micrometer.adoc Show resolved Hide resolved
docs/se/metrics/03_micrometer.adoc Show resolved Hide resolved
metrics/micrometer/src/main/java/io/helidon/metrics/micrometer/package-info.java Outdated Show resolved Hide resolved
@tjquinno tjquinno removed this from the 2.2.0 milestone Dec 17, 2020
@tjquinno
Copy link
Member Author

tjquinno commented Dec 21, 2020 •
edited
Loading

There is significant overlap between the Micrometer and the MP-inspired metrics support, in SE and MP. As a result, the most recent commits:

  • do away with the separate module for Micrometer support in SE,
  • abstract common behavior into a base class which MetricsSupport and MicrometerSupport both extend, and
  • move MicrometerSupport into the metrics/metrics module.

The Micrometer-related dependencies are marked as optional in the pom so only SE apps which actually use Micrometer support will trigger loading of the Micrometer-related classes.

@tjquinno tjquinno closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen left review comments

@tomas-langer tomas-langer tomas-langer requested changes

@barchetta barchetta Awaiting requested review from barchetta

@spericas spericas Awaiting requested review from spericas

Assignees

@tjquinno tjquinno

Labels
2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file enhancement New feature or request metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Micrometer support
4 participants
@tjquinno @tomas-langer @ljamen @barchetta