Support MP health 2.2 #2264
Merged
Support MP health 2.2 #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
|
Based on the failed tests, I guess there was a change in module name of the MP health? Seems the test using module path are failing... |
tomas-langer
requested changes
Aug 18, 2020
|
Re: the module issue -- Yes, I found this last night and am continuing to work on it this morning. The error message in the pipeline test and locally is this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2259
Minor adaptation to MicroProfile Health 2.2
There are very few substantive changes in the spec from 2.1 to 2.2. Even the changes in the PR are not really required, but they save us a tiny bit of code and illustrate in our code base the use of two (minor) additions to the MP health API.
I searched our code base for other opportunities to use other changes in MP health and found none.
Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com