Support for bean producers in different package than beans that have … #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…package local methods. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
ljnelson
reviewed
Aug 7, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Aug 7, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
ljnelson
previously approved these changes
Aug 7, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
ljnelson
reviewed
Aug 7, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Aug 10, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
- name is generated with super interface first - proxy classes are defined using private lookup when in original package - proxy classes are defined using a class loader for weld specific packages Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
- name is generated with super interface first - proxy classes are defined using private lookup when in original package - proxy classes are defined using a class loader for weld specific packages Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
ljnelson
reviewed
Aug 11, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
ljnelson
previously approved these changes
Aug 11, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
ljnelson
reviewed
Aug 12, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Aug 12, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
force-pushed
the
2223_producer_off_package
branch
from
8001e05
to
60eb535
Compare
ljnelson
reviewed
Aug 13, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Aug 13, 2020
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonProxyServices.java
Outdated
Show resolved
Hide resolved
ljnelson
previously approved these changes
Aug 13, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
ljnelson
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…package local methods.
Resolves #2223
Signed-off-by: Tomas Langer tomas.langer@oracle.com