Support for SE mappers in MP. #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Use direct APIs to retrieve booleans. Fixes to object mapping support in MP. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
ljnelson
previously requested changes
Jun 25, 2020
config/config-mp/src/main/java/io/helidon/config/mp/MpConfig.java
Outdated
Show resolved
Hide resolved
config/config-mp/src/main/java/io/helidon/config/mp/SeConfig.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Jun 25, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
reviewed
Jun 25, 2020
config/config-mp/src/main/java/io/helidon/config/mp/SeConfig.java
Outdated
Show resolved
Hide resolved
danielkec
previously approved these changes
Jun 25, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
approved these changes
Jun 25, 2020
tomas-langer
dismissed
ljnelson’s stale review
Changes are incorporated in latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2090
Signed-off-by: Tomas Langer tomas.langer@oracle.com