Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement ConcatPublisher + TCK test #1407

Closed
wants to merge 11 commits into from

Conversation

akarnokd
Copy link
Collaborator

Reimplement io.helidon.common.reactive.ConcatPublisher so it works as a properly reusable Flow.Publisher.

@danielkec danielkec self-assigned this Feb 20, 2020
@danielkec danielkec added the reactive Reactive streams and related components label Feb 24, 2020
spericas and others added 6 commits February 26, 2020 11:25
…ELP lines in Prometheus format as this is a violation that can be flagged by tools with validation enabled. This can happen for metrics with same name and different tags. We now keep track of TYPE and HELP lines added to format to avoid repetition. (helidon-io#1440)
@akarnokd
Copy link
Collaborator Author

I've been trying to restart failed builds but the button on Wercker doesn't work.

@romain-grecourt
Copy link
Contributor

@akarnokd I've restarted your pipeline, it failed with a javadoc error.

@akarnokd
Copy link
Collaborator Author

Could be this bug: https://bugs.openjdk.java.net/browse/JDK-8212233

@romain-grecourt
Copy link
Contributor

Not quite sure. We may have to disable links to get rid of this error. @barchetta FYI

@barchetta
Copy link
Member

barchetta commented Feb 27, 2020

Yes. In Helidon 2.0 we are moving to Java 11 javadocs and modules and all the headaches that means. Links continue to confound us -- in part due to JDK bugs. We're in the middle of re-working some of the javadoc generation, but have not yet sorted out the cross-reference issues.

Let me do a PR that turns off our link configuration. That might work-round this.

The other work-around is to change your @links to @code. But that's awfully gross.

Just noticed the build failed in spotbugs, not javadoc -- we currently have failOnError false for javadocs in master, right? So I don't think the javadoc error is blocking this PR.

@akarnokd
Copy link
Collaborator Author

I'll redo this PR from a fresh master and we'll see if that helps.

@akarnokd
Copy link
Collaborator Author

Submitted again in #1452.

@akarnokd akarnokd closed this Feb 27, 2020
@akarnokd akarnokd deleted the ConcatPublisherReimplement branch March 25, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reactive Reactive streams and related components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants