-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement ConcatPublisher + TCK test #1407
Conversation
…ELP lines in Prometheus format as this is a violation that can be flagged by tools with validation enabled. This can happen for metrics with same name and different tags. We now keep track of TYPE and HELP lines added to format to avoid repetition. (helidon-io#1440)
I've been trying to restart failed builds but the button on Wercker doesn't work. |
@akarnokd I've restarted your pipeline, it failed with a javadoc error. |
Could be this bug: https://bugs.openjdk.java.net/browse/JDK-8212233 |
Not quite sure. We may have to disable links to get rid of this error. @barchetta FYI |
Yes. In Helidon 2.0 we are moving to Java 11 javadocs and modules and all the headaches that means. Links continue to confound us -- in part due to JDK bugs. We're in the middle of re-working some of the javadoc generation, but have not yet sorted out the cross-reference issues. Let me do a PR that turns off our link configuration. That might work-round this. The other work-around is to change your Just noticed the build failed in spotbugs, not javadoc -- we currently have |
I'll redo this PR from a fresh master and we'll see if that helps. |
Submitted again in #1452. |
Reimplement
io.helidon.common.reactive.ConcatPublisher
so it works as a properly reusableFlow.Publisher
.